mumble-voip/mumble

Iterate through positional audio program names only once

Open

#5,712 opened on Jun 1, 2022

View on GitHub
 (4 comments) (2 reactions) (0 assignees)C++ (1,062 forks)batch import
clientfeature-requestgood first issue

Repository metrics

Stars
 (5,642 stars)
PR merge metrics
 (Avg merge 6d) (7 merged PRs in 30d)

Description

Context

Right now Mumble iterates through every program name of every PID for every positional audio plugin. This is quite wasted CPU time if either the PID count is high or plugin count is high, as the time complexity is in $\mathcal{O}(PIDNum \cdot pluginNum )$.

Example: https://github.com/mumble-voip/mumble/blob/dd5df45313a937359285327f556557159bab758e/plugins/gtav/gtav.cpp#L81

Description

A better solution would be if each plugin tells Mumble what program name it is looking for, so that only Mumble has to iterate over the PID-list once.

Mumble component

Client

OS-specific?

No

Additional information

This issue originated from https://github.com/mumble-voip/mumble/pull/5704#issuecomment-1141938952

Contributor guide

Research direction
Investigate how Mumble's positional audio plugins currently iterate over PIDs and propose a refactoring where each plugin declares its target program name, allowing Mumble to iterate the PID list once and dispatch to the matching plugin.
Tech stack
cpp
Domain
None
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Mumble plugin architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60