mumble-voip/mumble

Force TCP Mode does not affect incoming UDP stream

Open

#4,881 opened on Mar 21, 2021

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C++ (1,062 forks)batch import
bugclientgood first issue

Repository metrics

Stars
 (5,642 stars)
PR merge metrics
 (Avg merge 6d) (7 merged PRs in 30d)

Description

Describe the bug According to https://github.com/mumble-voip/mumble/blob/d6f9e97ad64828066d5134c9d87e2673847eed79/src/mumble/ServerHandler.cpp#L557

the third true parameter essentially disable the TCP mode check here: https://github.com/mumble-voip/mumble/blob/d6f9e97ad64828066d5134c9d87e2673847eed79/src/mumble/ServerHandler.cpp#L277

Which in this case, client keeps sending UDP ping regardless of TCP mode, trickling server thinking the client is capable of receiving UDP packet and keep sending them, rendering the option useless.

Expected behavior A clear and concise description of what you expected to happen.

Currently when this mode is enabled, only outgoing voice stream goes through TCP tunnel. Expected behavior is the incoming stream also passes through it.

Desktop (please complete the following information):

  • OS: Windows 10
  • Version: Mumble 1.3.4, with a custom server based on Grumble.

Contributor guide

Research direction
Inspect the TCP mode handling in ServerHandler.cpp around lines 277 and 557 to understand why UDP ping is sent regardless of TCP mode.
Tech stack
cpp
Domain
backendnetworking
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75