mumble-voip/mumble

Feature Request: Ability to change username

Open

#3,779 opened on Sep 1, 2019

View on GitHub
 (1 comment) (7 reactions) (0 assignees)C++ (1,062 forks)batch import
feature-requesthelp wanted

Repository metrics

Stars
 (5,642 stars)
PR merge metrics
 (Avg merge 6d) (7 merged PRs in 30d)

Description

Changing the own username is kinda the basic functionality one (or at least I) would expect to be possible. However it appears that this is only possible by disconnecting from the server and then reconnecting to it with a different name.

Once #3778 gets fixed, the double-click action for the own user should be free again which could be mapped to changing ones username.

If I understand the code correctly this would require to send a UserState message to the server that contains the desired username. https://github.com/mumble-voip/mumble/blob/987953c008f2d6ba205bc3734607106dafae5258/src/Mumble.proto#L167-L170

If this isn't possible (because e.g. the name is invalid or already in use) I assume the server would answer with a PermissionDeniedmessage with UserName as the "DenyType". https://github.com/mumble-voip/mumble/blob/987953c008f2d6ba205bc3734607106dafae5258/src/Mumble.proto#L279-L280

Contributor guide

Research direction
Study the Mumble protocol (Mumble.proto) to understand how UserState messages are sent and handled. Look at the client code for username changing and the server's response for PermissionDenied. Implement the UI and logic to send the UserState message when the user double clicks on their own name.
Tech stack
c
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++GitProtobuf
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60