mumble-voip/mumble

Connection Dialog Should Display Ping Issues (timeouts, packetloss)

Open

#3158 opened on Jul 9, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (5,642 stars) (1,062 forks)batch import
clientfeature-requesthelp wantedui

Description

I had internet connection issues the last two days and noticed the server stats are only updated on successful pings. That means that if you had 1 successful 30ms ping with user count and then none for 10 minutes the displayed info is 10 minutes old and wrong (/does not indicate connection issues).

If we start with timeouts we do not display anything. Maybe some negative feedback would be useful then as well (use case: user has only 1 favourite server; does not see that we ping unsuccessfully, connect button is greyed out).

Contributor guide

Tech stack
cpp
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++Qt
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests that the connection dialog display indicators for ping failures (timeouts, packet loss) and not just rely on successful pings. To implement this, one would need to modify the ping handling logic in the Mumble client, likely in the files related to the connection dialog (e.g., `src/mumble/Connection.cpp` or similar). The current behavior only updates stats on successful pings, so the fix involves detecting and displaying failed pings, possibly by showing a 'Connection Lost' or latency graph with missing data points.