mumble-voip/mumble

Settings window should be non-modal, and the "Apply" button should apply settings immediately

Open

#2734 opened on Jan 17, 2017

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (5,642 stars) (1,062 forks)batch import
feature-requesthelp wantedui

Description

Hi I am on the latest v1.3 snapshot (64bit) and it appears that the apply button does not work as it should.

Simple steps to reproduce:

  1. Open Preferences
  2. Go to User Interface and change the "layout"
  3. Press apply

The new layout will not be applied until restart. However pressing "OK" works as it should and applies the setting correctly.

Contributor guide

Tech stack
cpp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Qt frameworkMumble build systemC++ basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue reports that the Apply button in the Preferences window does not apply layout changes immediately, unlike the OK button. Investigate the event handling for the Apply button in the settings dialog. Look at files like `src/mumble/Settings.cpp` or `src/mumble/Preferences.ui` to understand the current behavior. Compare with the OK button logic. Ensure that the Apply button triggers the same apply logic as OK without closing the dialog. Consider whether making the window non modal is necessary for expected behavior.