mumble-voip/mumble

Improve Tor support for .onion hosts

Open

#1,812 opened on Sep 15, 2015

View on GitHub
 (8 comments) (1 reaction) (0 assignees)C++ (5,642 stars) (1,062 forks)batch import
clientfeature-requesthelp wanted

Description

It is not possible to use Tor's .onion hosts when using a SOCKS5 proxy. I believe this is because it is not possible to normally resolve these names and the SOCKS proxy (eg: Tor) does the resolution.

The connect wizard also removes the password field for .onion hosts. Ironically the password field may not be needed... if a user is using this with torsocks, I think this can be used to bypass access controls on a server as the connection is coming from localhost.

Contributor guide

Tech stack
cpp
Domain
backendsecurity
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
C++SOCKS5 proxyTor networkDNS resolution
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the connect wizard code in Mumble to understand how SOCKS5 proxy is handled. Look for DNS resolution logic and identify where .onion hostnames are rejected or mishandled. Check existing comments in the issue for hints on the required changes.