mumble-voip/mumble

WASAPIInput: only enable echo cancellation if the input device is the same as the output device

Open

#1,731 opened on Jun 28, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (1,062 forks)batch import
clientfeature-requesthelp wanted

Repository metrics

Stars
 (5,642 stars)
PR merge metrics
 (Avg merge 6d) (7 merged PRs in 30d)

Description

This issue came up in https://github.com/mumble-voip/mumble/issues/1722 where a user tried to use a USB soundcard with a USB desk mic. It didn't work, and it was not obvious what was wrong.

Contributor guide

Research direction
Inspect the WASAPI input code in Mumble to find where echo cancellation is enabled and add a check that only enables it if the input device ID matches the output device ID.
Tech stack
cpp
Domain
desktopaudio video rtc
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75