Potential import collision: import path should be "github.com/rdumont/assistdog", not "github.com/hellomd/assistdog"
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- go
- Domain
- build-system
Research direction
Start with test/go.mod and the repository search for hellomd/assistdog referenced in the issue. Review each matching Go import and dependency entry, then verify that the old path no longer appears and that the module dependencies do not retain the duplicate assistdog paths.
Written by the indexing model from the issue text.
Description
Background
I find that github.com/rdumont/assistdog and github.com/hellomd/assistdog coexist in this repo：
https://github.com/multiformats/multiaddr/blob/master/test/go.mod （Line 10 & 5）
github.com/hellomd/assistdog v0.0.0-20171107191847-c91d7a54538c
github.com/rdumont/assistdog v0.0.0-20171107191847-c91d7a54538c // indirect
That’s because the assistdog has already renamed it’s import path from "github.com/hellomd/assistdog" to "github.com/rdumont/assistdog". When you used the old path "github.com/hellomd/assistdog" to import assistdog, go will reintroduces assistdog through the import statements "import github.com/rdumont/assistdog/…" in the go source file of assistdog.
https://github.com/rdumont/assistdog/blob/c91d7a54538c6d66d976d4e71ad31b8661eddea3/assist.go#L11
package assistdog
import (
"github.com/DATA-DOG/godog/gherkin"
"github.com/rdumont/assistdog/defaults"
…
)
The "github.com/rdumont/assistdog" and "github.com/hellomd/assistdog" are the same repos. This will work in isolation, bring about potential risks and problems.
Solution
Replace all the old import paths, change "github.com/hellomd/assistdog" to "github.com/rdumont/assistdog ".
Where did you import it: https://github.com/multiformats/multiaddr/search?q=hellomd%2Fassistdog&unscoped_q=hellomd%2Fassistdog
- Dominant language
- Go
- Stars
- 482
- Forks
- 87
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from multiformats/multiaddr
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
multiformats/multiaddr#181 ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
multiformats/multiaddr#178 · 4 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 10/100
multiformats/multiaddr#168 ·
-
Multiaddr URI scheme Open
Difficulty 5/5 Over a week Newbie friendliness 25/100
multiformats/multiaddr#165 · 2 comments · 1 reaction ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
multiformats/multiaddr#156 · 1 reaction ·
All issues in multiformats/multiaddr
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
enhancement needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
kind/cleanup
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
kubernetes-sigs/kueue#15947 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
sympozium-ai/sympozium#627 ·