muicss/mui

Design help with typography

Open

#29 opened on Jun 26, 2015

View on GitHub
 (3 comments) (0 reactions) (1 assignee)JavaScript (4,524 stars) (441 forks)batch import
help wanted

Description

  1. font-smoothing

    I've been debating whether or not we should turn on font-smoothing by default. The css property makes text look better on webkit/mozilla browsers but it also results in some changes that might not be desirable (e.g. white text on dark backgrounds is more faint). For an end-user it's easier to add it than remove it in custom CSS so I've been hesitant to make it a MUI global property but it's frustrating when the default text with MUI doesn't look great out of the box.

    So far I've been considering 1) making font-smoothing a global property of MUI 2) making font-smoothing a local property for certain elements (e.g. buttons) 3) documenting the issue and letting the developer decide.

    Any thoughts?

  2. letter-spacing

    The current letter-spacing in MUI is based on Google's recommendations for Roboto but it isn't necessarily ideal for other fonts. Here's the difference between turning on/off MUI letter-spacing for buttons using MUI's default font (Helvetica Neue): octodev_8081_examples_buttons_html

    And here's the difference with font-smoothing turned on: octodev_8081_examples_buttons_html

    In keeping with the lightweight/minimalist spirit of MUI, I've been considering turning off the custom letter-spacing and leaving it up to the developer to choose the letter-spacing that works best for their font choice. Any thoughts?

Contributor guide

Tech stack
css
Domain
frontend
Issue type
research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Review the issue discussion about font smoothing and letter spacing in MUI. Examine the current CSS typography defaults in the repository (look for relevant CSS files). Consider the trade offs mentioned and propose a well reasoned recommendation. The issue is a discussion, so no code changes required, but a comment suggestion would be appropriate.