mswjs/msw

Bypassed requests miss cookie headers with axios + axios-cookiejar-support

Open

#2338 opened on Oct 29, 2024

View on GitHub
 (10 comments) (0 reactions) (1 assignee)TypeScript (13,302 stars) (422 forks)batch import
bughelp wantedscope:node

Description

Prerequisites

Environment check

  • I'm using the latest msw version
  • I'm using Node.js version 18 or higher

Node.js version

20.17.0

Reproduction repository

https://github.com/aristofun/bugs-js-msw

Reproduction steps

Minimal example: https://github.com/aristofun/bugs-js-msw

Change the msw version to 2.4.3 reinstall and yarn start to see the difference.

Current behavior

After mswServer.listen({ onUnhandledRequest: "bypass" }); all localhost requests issued by axios in the same process are stripped off all cookie headers.

Reproduced on all msw versions starting with 2.4.4

Explicitly adding cookie header like this:

 const result2 = await axios.post("/mypath", {}, { headers: { 'Cookie': 'key=value' } });

Works. That means the problem is with interference with axios-cookiejar-support

Expected behavior

mswServer.listen({ onUnhandledRequest: "bypass" }); should not interfere with axios-cookiejar-support

Contributor guide

Tech stack
typescriptnodejs
Domain
backendtesting
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptNode.jsaxioscookie handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Examine the reproduction repository (https://github.com/aristofun/bugs js msw) to replicate the issue. Review the msw source code, particularly the request interception logic and the handling of the `onUnhandledRequest: 'bypass'` option. Check the git history for changes between versions 2.4.3 and 2.4.4 to identify the commit that introduced the regression. Look for any comments from the assignee or maintainers in the issue #2338 for guidance on expected behavior.