mqtt-tools/mqttwarn

[APNS] Migrate to `apns2` or `aioapns`

Open

#580 opened on Aug 22, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (930 stars) (184 forks)batch import
help wantedservice plugin

Description

Hi there,

@LaborEtArs asked at https://github.com/jpmens/mqttwarn/issues/396#issuecomment-575877788:

Are there plans to update the apns plugin to apns2?

apns did not receive any updates since 2015, apns2 does a better job here, the most recent release is from 2020. So, indeed, the plugin should be updated accordingly.

With kind regards, Andreas.

Contributor guide

Tech stack
python
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
PythonAPNSMQTT
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Examine the existing APNS plugin code in the repository (likely mqttwarn/plugins/apns.py). Review the apns2 library documentation to understand the new API. Consider whether to use apns2 or aioapns based on async requirements. Implement the migration by replacing the apns library calls with apns2, ensuring backward compatibility where possible. Update tests and documentation accordingly.