mozilla/webmaker-core

Add icon component

Open

#42 opened on Jul 14, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (31 forks)auto 404
enhancementhelp wanted

Repository metrics

Stars
 (63 stars)
PR merge metrics
 (PR metrics pending)

Description

This issue has been migrated from mozilla/webmaker-android#1584.

It was originally written by k88hudson on Tue Apr 28 2015 and had the following description:

We need this to support multiple colours, maintain consistent size etc.

On Thu Apr 30 2015, k88hudson commented:

I would love to have an icon font, but a component will do for now.

On Fri May 01 2015, Pomax commented:

Why not both? We can make an <Icon> component that serves up "whatever works" while we work on it, so we can use a JSX syntax like <Icon type="eyeball" /> and have that either generate an svg image or, once we find a nice one, text span with an icon font.

Contributor guide

Research direction
Investigate existing icon implementations in the codebase and create a reusable Icon component supporting SVG or icon fonts with color and size props.
Tech stack
javascriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70