mozilla/webmaker-core

Possible to end up in Play mode with a higher than max zoom level

Open

#145 opened on Jul 14, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (31 forks)auto 404
bugfeedbackhelp wanted

Repository metrics

Stars
 (63 stars)
PR merge metrics
 (PR metrics pending)

Description

This issue has been migrated from mozilla/webmaker-android#1995.

It was originally written by flukeout on Fri May 22 2015 and had the following description:

Steps to reproduce

  • Edit a project
  • Enter play mode
  • Tap a page to zoom in
  • Exit play mode and go back to the editor
  • Enter play mode
  • The view is in "map view & pan mode", but the page size suggests the 'swipe zoomed in mode'
  • When you attempt to zoom pinch from this state, the map zoom level immediately, and jarringly jumps back the max zoom level

We still have to sort out what zoom level and state we should start Play mode in though.

On Fri May 22 2015, thisandagain commented:

:+1: Good catch.

Contributor guide

Research direction
Investigate how zoom state is saved and restored when switching between edit and play modes. Trace the state management flow to find where the zoom level exceeds the maximum and ensure it resets properly.
Tech stack
javascriptreact
Domain
frontendmobile dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70