mozilla/webmaker-core

Button height changes when the label is blank

Open

#142 opened on Jul 14, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (31 forks)auto 404
enhancementfeedbackhelp wanted

Repository metrics

Stars
 (63 stars)
PR merge metrics
 (PR metrics pending)

Description

This issue has been migrated from mozilla/webmaker-android#1989.

It was originally written by flukeout on Thu May 21 2015 and had the following description:

Steps to reproduce

  • Edit a button
  • Remove all the text in the label
  • Tap away from the button in the preview
  • The button changes height

It should stay the same height, even with no content

Contributor guide

Research direction
Inspect the button component's CSS and state handling to trace why height changes when label is empty.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60