mozilla/webmaker-core

Pages become slightly smaller when they get the selected border

Open

#110 opened on Jul 14, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (31 forks)auto 404
enhancementfeedbackhelp wanted

Repository metrics

Stars
 (63 stars)
PR merge metrics
 (PR metrics pending)

Description

This issue has been migrated from mozilla/webmaker-android#1835.

It was originally written by flukeout on Tue May 12 2015 and had the following description:

Let's make all pages appear the same size.

On Tue May 12 2015, thisandagain commented:

Tried resolving this by moving the border from the selected class to the base class for each page, but it caused major performance problems. Not sure why ... needs investigation but any potential fix for this should be tested for perf.

Contributor guide

Research direction
Investigate the performance impact of moving the border from the selected class to the base class for each page, and find a way to keep page sizes consistent without causing performance issues.
Tech stack
javascriptreactcss
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitCSSReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75