Repository metrics
- Stars
- (63 stars)
- PR merge metrics
- (PR metrics pending)
Description
This issue has been migrated from mozilla/webmaker-android#1833.
It was originally written by flukeout on Tue May 12 2015 and had the following description:
Implementation
Replace single-line text editor with multi-line text editor
STATUS: Design in progress
Original notes (filed by flukeout):
Steps to reproduce
- Add a text element, and edit it
- Change the text to "asdf asdf asdf asdf asdf asdf asdf asdf asdf asdf" or "asdfasdf asdfasdf asdfasdf asdfadsf asdfadsf" or maybe even "asdfjjak kdjf ldkjf k dlfkj dlkfj adsklf jas"
- Or anything that has a lot of words and spaces!
- You'll notice that the preview will wrap the words across multiple lines
- Confirm the changes and return to the Page Editor
- The Text Element displays the text you typed all on one line
I know we're replacing the text editor, but this issue may still persist so we should be aware of it. We need to figure out how to handle the UX of wrapping and line breaks.
On Fri May 15 2015, Pomax commented:
should be fixed with https://github.com/mozilla/webmaker-android/pull/1877
On Mon May 25 2015, secretrobotron commented:
Just tried this with latest nightly. Text doesn't wrap in editor either, and is always slightly misaligned.
On Mon May 25 2015, secretrobotron commented:
Blocks mozilla/webmaker-android#1665
On Fri Jun 05 2015, secretrobotron commented:
cc **@**k88hudson
On Tue Jun 09 2015, k88hudson commented:
**@**vazquez can you add a comp/design spec for the multiline text editor?
Notes from our discussion:
- text editor should be vertically centered in preview window
- pressing enter should add a line break instead of exiting the editor
- users should use the hide keyboard button to dismiss keyboard
Note that if the editor is styled appropriately, there shouldn't really be a reason to ever hide it/replace it with a non-editable version (it can just always be shown)
On Tue Jun 09 2015, k88hudson commented:
cc **@**Pomax
On Tue Jun 09 2015, xmatthewx commented:
Will we implement resize of text container in the page view? Getting that to feel right is the bit that concerns me.
On Tue Jun 09 2015, k88hudson commented:
**@**xmatthewx If you think it would bee easier, having the textarea fill the entire preview and have text top-aligned would be better than nothing -- however, I was hoping we could go for something like this http://codepen.io/desandro/pen/gICqd
On Tue Jun 09 2015, vazquez commented:
So something like this:
On Tue Jun 09 2015, k88hudson commented:
**@**vazquez awesome, thanks!
On Tue Jun 09 2015, xmatthewx commented:
**@**k88hudson - I trust your plan for the preview area.
I'm wondering about transforms on the Page view. Does a pinch still scale multi-line font-size? Spec includes a handle to allow users to resize the container and change the flow of text. Do you think implementation of that handle will be easy? If so, then we're golden. If not, we do we have a plan B?
On Tue Jun 09 2015, k88hudson commented:
**@**xmatthewx in this case, we decided on manual line breaks (with enter) and keeping resize the way it is as an interim solution, since implementing a new resize paradigm is too much for the remaining time we have. Is that OK with you?
On Tue Jun 09 2015, xmatthewx commented:
:+1: Works for me as an interim solution. Sorry if I missed that detail somewhere.
On Tue Jun 09 2015, k88hudson commented:
No worries! There is a surprising amount of complexity here, thanks for following up :)
On Wed Jun 10 2015, k88hudson commented:
As discussed we are going to push this out of beta and go with a simple interim solution instead due to time constaints. https://github.com/mozilla/webmaker-android/pull/2149/files
On Wed Jun 10 2015, secretrobotron commented:
:+1: yay!
For followup: still unable to justify text and use an enter button for newlines.