mozilla/send

[Send 2][Enhancement] Clicking inside the “Privacy” overlay should dismiss it

Open

#1,304 opened on Apr 22, 2019

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (13,154 stars) (1,239 forks)batch import
[QA]:Enhancementgood first issueskill:js

Description

[Notes]:

  • There should be consistency regarding the dismissal of the overlay considering that the upload complete and Sign in/up overlays are dismissed when clicking inside them.

[Affected versions]:

  • Firefox 66.0.3 and up
  • Chrome Version 73.0

[Affected Platforms]:

  • All Mac
  • All Windows
  • All Linux

[Steps to reproduce]:

  1. Open the browser and navigate to the https://send.firefox.com/ website.
  2. Click the “Privacy” button.
  3. Click inside the overlay but not on any actionable buttons.

[Expected result]:

  • The overlay is dismissed.

[Actual result]:

  • The overlay is still displayed.

[Additional Notes]:

rec of issue - overlay dismissal

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptFamiliarity with event handling in the browser
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue requires adding a click handler to dismiss the Privacy overlay when clicking inside it (but not on actionable buttons). Look at how other overlays (upload complete, sign in/up) handle dismissal for consistency. The codebase is likely JavaScript with HTML/CSS. Check the overlay component and its event listeners. Review the 6 comments on the issue for any additional context or attempted solutions.