mozilla/sccache

Add a higher-level interface to RunCommand

Open

#95 opened on Mar 28, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (677 forks)github user discovery
help wanted

Repository metrics

Stars
 (7,329 stars)
PR merge metrics
 (Avg merge 28d 22h) (11 merged PRs in 30d)

Description

@alexcrichton pointed out that the compiler implementations had some repetitive and potentially error-prone code for spawning processes with my changes in #92. Specifically for each compiler invocation it has to call cmd.env_clear().envs(...) to properly set the environment. We should add a higher-level interface here so that it's harder to make a mistake in this code.

Contributor guide

Research direction
Examine the existing RunCommand struct and its usage in compiler invocations to identify the repetitive env clear and envs patterns. Propose a higher level abstraction that encapsulates environment setup.
Tech stack
rust
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50