mozilla/multi-account-containers

Intermittent back button issue prevent editing containers

Open

#2437 opened on Nov 1, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,341 stars) (304 forks)batch import
Component: PanelStatus: Confirmedbuggood first issuehelp wanted

Description

Before submitting a bug report

  • I updated to the latest version of Multi-Account Container and tested if I can reproduce the issue
  • I searched for existing reports to see if it hasn't already been reported

Step to reproduce

  1. Install the 8.1.0 version of Multi-Account Containers
  2. Open the Multi-Account Containers pop-up select any available container via the “>” button beside the container
  3. Click on “Manage this Container” button
  4. Once on the container detail page, rename the container to something else, change the icon and color
  5. Click the “Back” button to return to the previous panel
  6. Notice that sometimes, the “back” button does not work immediately as it requires multiple clicks in order to return to the previous panel. It, however, instead highlights the container name field and resets it to it’s previous value thus not saving the customization of that container. Color and icon are also not taken into account and reset.

Actual behavior

The “Back” button does not always work and causes changes to containers to be reset.

Expected behavior

The “Back” button should return the user to the previous panel and not affect container customization saving.

Additional informations

There might be a related issue regarding the “Back” button here: https://github.com/mozilla/multi-account-containers/issues/1857.

https://user-images.githubusercontent.com/50236075/199227776-807c0af6-9621-483f-bf80-efa5cffd9c78.mp4

Provide a copy of Troubleshooting Information page (optional)

No response

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
understanding of Firefox add onsJavaScriptstate management
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the back button navigation logic in the popup, likely in a React or similar component. Focus on the container editing panel and how changes to name, icon, and color are saved or reset. Check related issue #1857 for potential duplicate or root cause. Look for event handlers for the back button and state management code that might cause the intermittent behavior.