mozilla/mentat

Make query builder generalize past `&mut Store`

Open

#652 opened on Apr 23, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Rust (116 forks)github user discovery
A-queryenhancementhelp wanted

Repository metrics

Stars
 (1,661 stars)
PR merge metrics
 (PR metrics pending)

Description

Right now, the query builder exposes a simple interface that accepts &mut Store. It's pretty restrictive, since Store is a simple type and since taking a mutable reference enforces linear ordering.

This ticket tracks allowing callers to provide something that can yield the pair of Conn and SQLite connection, so that callers that care about their own connection management can take care of things on their own.

As an aside, I'm surprised that this is as restrictive as I am finding it while writing tests!

Contributor guide

Research direction
Examine the current query builder's interface to understand how it uses `&mut Store`. Then design a trait that abstracts the connection retrieval, allowing callers to implement custom connection management.
Tech stack
rust
Domain
backenddatabase
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40