Don't add 'topcrash' keyword back, if a human has removed it and there's another bug with the same signature and the 'topcrash' keyword

Open
#2,785 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
backend, tooling

Research direction

Start by locating the bugbot logic that adds the topcrash keyword and review how it handles shared crash signatures. Reproduce the case described with multiple open bugs sharing a signature, one retaining topcrash and one having it removed. Done means the bot does not restore the keyword to the latter when another matching bug still tracks it.

Written by the indexing model from the issue text.

Description

(Context: https://bugzilla.mozilla.org/show_bug.cgi?id=2007715#c7 and following failed attempts to remove the topcrash signature)

Sometimes we have multiple distinct bugs that happen to share the same crash-signature. If one of them happens to be a topcrash (making the shared crash-signature show up as a topcrash), then bugbot adds the topcrash signature to all bugs with that signature.[1]

This makes it look (on e.g. dashboards like https://bugdash.moz.tools/ ) like we have multiple distinct topcrashes, when in fact we only have one bug that's a topcrash (and some others that happen to share the same signature but have much lower crash volume).

After making this determination, a human engineer (e.g. me in https://bugzilla.mozilla.org/show_bug.cgi?id=2007715#c7 ) may decide to remove the topcrash signature from the low-volume bugs, but bugbot will just add it back (modulo [1]).

After discussing this situation with @suhaibmujahid , we think maybe it'd make sense for the bot to not add the keyword back in this situation, IF there's another bug open that shares the same crash signature, and that bug has the topcrash keyword (so the bot can be confident that the topcrash is still tracked somewhere).

(Not sure if this is common enough to bother adding this logic, but filing this issue as a reminder to look into it if this comes up again.)

[1] (one exception where the bot doesn't add the topcrash keyword is where the bot itself has previously removed it from that bug, e.g. for crashes that drift onto & off of & back onto the topcrash list)

Dominant language
Python
Stars
68
Forks
92
Avg merge
2d 2h
Merged PRs (30d)
16

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mozilla/bugbot

All issues in mozilla/bugbot

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.