mozilla/adr

`extra/docker/run-adr` script doesn't allow --ref after the repository

Open

#39 opened on Dec 12, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (8 forks)auto 404
buggood first issue

Repository metrics

Stars
 (4 stars)
PR merge metrics
 (PR metrics pending)

Description

The script's ArgumentParser will treat --ref foo as the recipe name rather than an argument to the script itself. So the only way to use it is to run:

$ ./run-adr --ref foo user/repo <recipe>

This is somewhat annoying and un-intuitive.

Contributor guide

Research direction
Examine the argparse configuration in `extra/docker/run adr` to understand why ` ref` is not parsed correctly when placed after the repository argument. Consider reordering arguments or using parse known args().
Tech stack
python
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75