mozilla/DeepSpeech

Handle control-C cleanly in feeding threads

Open

#2,914 opened on Apr 17, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (4,093 forks)batch import
help wanted

Repository metrics

Stars
 (26,755 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Currently you have to hold Control-C for several seconds until all the threads are killed.

Contributor guide

Research direction
Investigate how threads are managed during shutdown in the feeding loop and implement proper signal handling to catch SIGINT and gracefully terminate all threads.
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Multithreading
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60