Refactor how commitalert handles a new job

Open
#356 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Start with vendoring.py and trace how vendoring tasks create a job before processing, then compare that flow with the commitalert task entry point. Done means commitalert follows the same initial job-creation behavior so failures do not continually reprocess the job.

Written by the indexing model from the issue text.

Description

Enhancement Medium

In vendoring.py for vendoring tasks, we refactored things so that the first thing we ever do is create a job in the table. This means that if something goes wrong, we won't try continually processing the job.

We don't have the same design for commitalert tasks. (They're a lot rarer, so this hasn't ever come up.) We should probably change how commitalert works so it works similarly.

Dominant language
Python
Stars
9
Forks
8
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mozilla-services/updatebot

All issues in mozilla-services/updatebot

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.