Teach CoT verify about github-pull-request-untrusted `tasks_for`

Open
#563 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
security

Research direction

Start in src/scriptworker/cot/verify.py at the condition around line 1315, and review how CoT verification handles existing tasks_for values. Confirm how the github-pull-request-untrusted value from D157493 should be recognized; done means verification accepts this new value correctly.

Written by the indexing model from the issue text.

Description

This is a new value that's possible after:
https://phabricator.services.mozilla.com/D157493

Might be as simple as adding a second condition to this if statement:
https://github.com/mozilla-releng/scriptworker/blob/c711a7b467abdc48d9d66ffffd67c88b7fa34003/src/scriptworker/cot/verify.py#L1315

Dominant language
Python
Stars
5
Forks
39
Avg merge
4h 18m
Merged PRs (30d)
6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mozilla-releng/scriptworker

All issues in mozilla-releng/scriptworker

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.