revisit `context.projects`
@jcristau is already working on this.
Since Sep 14, 2022.
Assessment
This issue has not been assessed yet.
Description
Aiui, we:
- updated autoland's scm level
- started failing cot because
context.projectsis cached over the lifetime of a running scriptworker. We couldawait context.populate_projects(force=True), but we never call that from anywhere in the code.
One potential solution here is:
- add a timestamp for when we populate
context.projects, e.g.context._projects_timestamp. We should update this on the projects setter. - add a config item for how long to cache
context.projectsifforce=False. - if we're past the TTL of the cache, update
context.projectseven ifforce=False.
Also this:
09:28 < aki> are there any outstanding cot questions? or all resolved
09:30 < tomprince> aki: All resolved, I think. I think we should consider making scriptworker use ci-admin to get the repository level, rather than having it understand the config format directly.
09:30 < aki> ok
09:30 < tomprince> aki: https://hg.mozilla.org/ci/ci-configuration/rev/745b0dce17f8 is what caused the breakage, I think.
09:33 < jlorenzo> sounds like a good fix
09:34 < aki> it's a lot more heavy weight than downloading a file, but it's doable. could we have ci-{configuration,admin} automation generate an artifact that scriptworker consumes?
09:35 < aki> that would avoid having to clone ci-{configuration,admin} everywhere we want to verify cot. i imagine we'll want to add cot verification to all artifact downloads in the graph at some point
This is the first time I know of that we've hit this issue, so this might not be super urgent. Good to address though.
- Dominant language
- Python
- Stars
- 5
- Forks
- 39
- Avg merge
- 4h 18m
- Merged PRs (30d)
- 6
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mozilla-releng/scriptworker
-
Dependency Dashboard Open
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
mozilla-releng/scriptworker#748 ·
-
mozilla-releng/scriptworker#645 · 4 comments · 1 assignee ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
mozilla-releng/scriptworker#584 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
mozilla-releng/scriptworker#580 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
mozilla-releng/scriptworker#570 ·
All issues in mozilla-releng/scriptworker
Similar issues
-
documentation help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
simonw/sqlite-utils#872 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100