mozilla-mobile/firefox-ios

[Glean] Migrate TermsOfUseTelemetry to use the GleanWrapper instead

Open

#29,805 opened on Oct 3, 2025

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Swift (12,950 stars) (3,203 forks)batch import
Contributor OKGood first issue

Description

:rocket: Context

TermsOfUseTelemetry is recording telemetry events with the concrete Glean implementation. We don't want this anymore. More on telemetry tests here.

:memo: Description

  • Use the GleanWrapper inside TermsOfUseTelemetry and replace calls to each GleanMetrics. with the corresponding API.
  • TermsOfUseTelemetryTests should be adjusted so we pass a MockGleanWrapper and assert accordingly.

:information_source: Reference Person

lmarceau

┆Issue is synchronized with this Jira Task

Contributor guide

Tech stack
swift
Domain
mobiletesting
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
SwiftGlean telemetryUnit testing in iOS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Look at the TermsOfUseTelemetry.swift file to understand current Glean calls. Examine GleanWrapper.swift to see the wrapper API. Review the wiki on Glean testing for unit tests. Then adjust TermsOfUseTelemetry to use GleanWrapper and update TermsOfUseTelemetryTests to use MockGleanWrapper.