mozilla-mobile/firefox-ios

[RTL] Focus iOS: The "Done" button text in settings is possibly too close to the screen edge?

Open

#25,647 opened on Mar 29, 2025

View on GitHub
 (4 comments) (0 reactions) (1 assignee)Swift (3,203 forks)batch import
Contributor OKGood first issue

Repository metrics

Stars
 (12,950 stars)
PR merge metrics
 (Avg merge 3d 2h) (221 merged PRs in 30d)

Description

:page_facing_up: Description

I'm not sure if this an actual issue or if my eyes are deceiving me, but I think the Done button in the RTL version is more close to the screen edge than an LTR version. RTL:

width=200,height=183

LTR:

width=200,height=183

Screenshots taken from: https://drive.google.com/drive/folders/12NNBfysXP_azTPrbBidDGdLYLtEy_izV and https://drive.google.com/drive/folders/1CUajrGqpQEJb7NqeQ1b1vqL0lnyaVAJA

:information_source: Reference Person

@FilippoZazzeorni

┆Issue is synchronized with this Jira Task

Contributor guide

Research direction
Inspect the layout constraints for the 'Done' button in the settings view, ensuring they account for right to left (RTL) layouts correctly. Check for leading/trailing constraints that might not be respecting the layout direction.
Tech stack
swift
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftiOS layout
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70