mozilla-mobile/firefox-ios

Add function_body_length to .swiftlint.yml

Open

#24,679 opened on Feb 11, 2025

View on GitHub
 (25 comments) (0 reactions) (1 assignee)Swift (3,203 forks)batch import
Contributor FixContributor OKGood first issue

Repository metrics

Stars
 (12,950 stars)
PR merge metrics
 (Avg merge 3d 2h) (221 merged PRs in 30d)

Description

Like it was done for closure_body_length add function_body_length to .swiftlint.yml with an high threshold in order to avoid a lot of warning. This task is an iterative one since the scope is to reduce the threshold and keep solving the lint issue gradually in small PRs.

The achievement threshold is set to 50 lines.

┆Issue is synchronized with this Jira Task

Contributor guide

Research direction
Open the existing .swiftlint.yml file, locate the closure body length configuration, and add a similar line for function body length with a threshold of 50 lines. Then submit a pull request.
Tech stack
None
Domain
mobile
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftSwiftLint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90