mozilla-mobile/firefox-ios

SwiftLint pre-push hook is not catching redundant type declarations in TabLocationView

Open

#24,412 opened on Jan 28, 2025

View on GitHub
 (3 comments) (0 reactions) (1 assignee)Swift (3,203 forks)batch import
Contributor FixContributor OKGood first issue

Repository metrics

Stars
 (12,950 stars)
PR merge metrics
 (Avg merge 3d 2h) (221 merged PRs in 30d)

Description

:page_facing_up: Description

Currently it appears that SwiftLint run locally on main will not catch redundant type declarations in TabLocationView.swift (and, likely, other files). This is true for SwiftLint 0.58.x, however SwiftLint 0.53.0 does correctly catch the error.

More context and information in this Slack thread.

:information_source: Reference Person

@FilippoZazzeroni

┆Issue is synchronized with this Jira Task

Contributor guide

Research direction
Compare SwiftLint 0.53.0 and 0.58.x configurations for the redundant type rule, and test against TabLocationView.swift to identify the regression.
Tech stack
swift
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
SwiftSwiftLintGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60