mozilla-mobile/firefox-ios

AR QuickLook - Buttons overlap with status bar on iOS 18

Open

#22,453 opened on Oct 9, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Swift (3,203 forks)batch import
Bug 🐞Contributor OKGood first issue

Repository metrics

Stars
 (12,950 stars)
PR merge metrics
 (Avg merge 3d 2h) (221 merged PRs in 30d)

Description

:page_facing_up: Description

Bugfix the AR buttons going under the status bar.

:1234: Steps to reproduce

  1. Set vertical device orientation
  2. Open https://developer.apple.com/augmented-reality/quick-look/
  3. Tap on any USDZ model link / image.

Expected behavior

AR QuickLook preview is open and X / Share buttons can be used.

Actual behavior

AR QuickLook preview is open but X / Share buttons cannot be used, overlapped by the status bar.

Device & build information

  • Device: iPhone 12 Pro iOS 18.0.1, iPhone 13 iOS 18.0
  • Build version: 131 (45816)
  • First seen version: ?

*# *## Notes Attachments:

width=200,height=183

:information_source: Reference Person

@FilippoZazzeroni

┆Issue is synchronized with this Jira Task

Contributor guide

Research direction
Check the AR QuickLook view controller's button layout. Ensure the buttons are positioned using safe area layout guides, especially on iOS 18 where status bar behavior might have changed. Test on devices with different notch types and orientations.
Tech stack
swift
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
iOS developmentSwiftAR QuickLook basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65