mozilla-mobile/firefox-ios

“Go to copied link?” toast is missing “Paste” button when using larger text sizes

Open

#22,247 opened on Sep 29, 2024

View on GitHub
 (12 comments) (0 reactions) (0 assignees)Swift (3,203 forks)batch import
Bug 🐞Contributor OKGood first issue

Repository metrics

Stars
 (12,950 stars)
PR merge metrics
 (Avg merge 3d 2h) (221 merged PRs in 30d)

Description

Steps to reproduce

  1. Open a page in Firefox.
  2. Switch to another app.
  3. Copy a URL from the other app.
  4. Switch back to Firefox

Expected behavior

Firefox should show the “Go to copied link?” with an “Go” button.

Actual behavior

Firefox shows the “Go to copied link?” with a button, but the button has no text label.

Device & build information

  • Device: iPhone 15 Plus running iOS 18.0
  • Build version: Firefox 9000 (45786)
  • First seen version:

Notes

I suspect this bug is a regression caused by updating to iOS 18.0 (from iOS 17.7): I know the copied link banner’s button text used to be visible, but it’s not shown in Firefox 130.1 or any of the Nightly versions available in TestFlight going back at least 88 days.

image

┆Issue is synchronized with this Jira Task

Contributor guide

Research direction
Investigate the "Go to copied link?" toast banner view. Check if the button title is properly set and if larger text sizes cause the label to be clipped or hidden. Look for any constraints or font adjustments that may not account for dynamic type.
Tech stack
swift
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftiOS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65