motioneye-project/motioneye

Example Config is IPv4-only, yet tornado supports IPv6

Open

#779 opened on Jan 29, 2018

View on GitHub
 (25 comments) (0 reactions) (0 assignees)Python (636 forks)batch import
help wantedquestion

Repository metrics

Stars
 (3,533 stars)
PR merge metrics
 (Avg merge 16d 14h) (33 merged PRs in 30d)

Description

Given this day in age where IPv4 addresses are exhausted, and 20% of the traffic on the internet is IPv6, it would be great to see MotionEye support IPv6 as well.

Looking into the code a bit, it appears that a small change to the settings.py will enable MotionEye to support IPv6 (at least for the control webserver). The current settings.py has:

# the IP address to listen on
# (0.0.0.0 for all interfaces, 127.0.0.1 for localhost)
LISTEN = '0.0.0.0'

Yet, setting LISTEN to an empty string will enable the tornado webserver to listen on both IPv4 AND IPv6

# the IP address to listen on
# (0.0.0.0 or :: for all interfaces, 127.0.0.1 or ::1 for localhost, blank for both IPv4 & IPv6)
LISTEN = ''

At a minimum it would be nice if the comments reflected support for IPv6, and perhaps the default settings.py could be a blank string, enabling both IPv4 AND IPv6 support for your fine software.

Contributor guide

Research direction
Modify the LISTEN setting in settings.py from '0.0.0.0' to an empty string '' to enable IPv6 support. Test the change locally by running MotionEye and accessing it via both IPv4 and IPv6 addresses.
Tech stack
python
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90