moroshko/react-autosuggest

Selecting text in popup breaks closing/on-blur

Open

#746 opened on May 25, 2020

View on GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (5,936 stars) (637 forks)batch import
bughelp wanted

Description

Codepen: https://codepen.io/moroshko/pen/vpBzMr (one from example page)

Browser: Google Chrome Version 83.0.4103.61 (Offizieller Build) (64-Bit) OS: Win 10 Pro

Steps to reproduce:

  • type in smt in input: popup opens
  • mark text in it
  • click autoside of popup: it doesn't close (on-blur also is not fired)
  • click on an element: popup closes
  • type smt new in input: popup opens
  • click outside: Popup doesn't close (on-blur also is not fired)
  • from here the open/close is broken

Example as GIF: mark-closing-issue

Contributor guide

Tech stack
reactjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic React knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the onBlur handling in the Autosuggest component. The issue occurs when selecting text inside the popup, which prevents the blur event from firing. Look at the event handling in the component's source code, particularly the blur handler and how it interacts with the popup's focus management. Consider using event delegation or checking the relatedTarget to determine if the focus moved within the popup.