moroshko/react-autosuggest

Escape key in IE11 not working

Open

#706 opened on Jan 6, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,936 stars) (637 forks)batch import
bugcross-browser compatibilityhelp wanted

Description

You can see the code here https://codepen.io/E-The-Man/pen/wvBpLLJ

  • Provide the steps to reproduce the issue, e.g.:
  1. Click on a button to open the searchbar
  2. Press the Escape key to close the searchbar
  3. The searchbar closes in every other browser including Edge, it doesn't close in IE11. The searchbar closes when you click outside the component.

  • Please describe your use case from user journey point of view, e.g.:

    When a user clicks on a button, it launches the auto-suggest search bar. A user should then be able to close the search bar by pressing the Escape key. This works as expected in all browsers except IE11.

Contributor guide

Tech stack
javascriptreact
Domain
frontendaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Reactevent handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate how IE11 handles the Escape key event differently. Check the event's key, keyCode, or which properties. Look at the component's onKeyDown handler in the source code. Consider using a polyfill or standardizing on key property. Test the codepen provided in IE11 to reproduce.