moroshko/react-autosuggest

Warning about `componentWillReceiveProps` in React's Strict Mode

Open

#624 opened on Mar 16, 2019

View on GitHub
 (9 comments) (54 reactions) (0 assignees)JavaScript (5,936 stars) (637 forks)batch import
help wanted

Description

React's Strict Mode warns about "Unsafe lifecycle methods were found within a strict-mode tree".

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead.

https://github.com/moroshko/react-autosuggest/blob/d626cef720df0ed5a4c7df4d539836b86bda6afa/src/Autosuggest.js#L124-L143

Contributor guide

Tech stack
reactjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React lifecycle methods
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The issue is to update the Autosuggest component to replace the deprecated `componentWillReceiveProps` lifecycle method with `getDerivedStateFromProps` as per React's Strict Mode warning. The relevant code is in `src/Autosuggest.js` around lines 124-143. The fix should follow React's official documentation on migrating from legacy lifecycle methods. No additional changes are required.