morelinq/MoreLINQ

Revise tests to avoid using `Eumerable.Range`

Open

#1,044 opened on Nov 16, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C# (3,495 stars) (406 forks)batch import
Component-Testsgood first issuehelp wanted

Description

Starting with .NET 8, Eumerable.Range returns an instance of a private RangeIterator that implements IList<T> (see also dotnet/runtime#88249). A lot of the unit tests potentially went with the assumption that Eumerable.Range returns a pure sequence. There are some operators in MoreLINQ that are optimised for sources that are collections and/or lists so tests using Eumerable.Range may be testing those optimised paths rather than the actual intended path iterating the source as an IEnumerable<>. Those tests need to be revised to avoid Enumerable.Range altogether.

Potential candidates that need revision:

Contributor guide

Tech stack
csharp
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic C#Unit testingLINQ knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Start by picking a few test files from the list (e.g., AggregateTest.cs, AppendTest.cs) in the MoreLinq.Test directory. Replace all uses of Enumerable.Range with a sequence that does not implement IList<T> (e.g., create a helper method that returns a custom IEnumerable<int> or use Enumerable.Range.AsEnumerable() to force non optimized path). Run the tests to ensure they still pass. Gradually apply to all listed files.