monicahq/monica

Create a command to execute all commands that we need to run before pushing final commit to a PR

Open

#1158 opened on Apr 12, 2018

View on GitHub
 (1 comment) (0 reactions) (1 assignee)PHP (24,641 stars) (2,464 forks)batch import
feature requesthelp wantedproductivity tools

Description

Each time we need to push our final commit to a PR, we need to

  • php artisan lang:generate
  • npm run prod

And sometimes other stuff too.

Perhaps we could create a command php artisan finalize:pr or something that would do that for us.

Contributor guide

Tech stack
phpjavascript
Domain
clideveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic Laravel structureFamiliarity with Artisan commands
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue requests a new Artisan command that runs `php artisan lang:generate` and `npm run prod`. To implement, look at existing commands in the `app/Console/Commands` directory to understand the pattern. For executing other Artisan commands, use the `Artisan::call()` facade. The command should be registered in `app/Console/Kernel.php`. Also, note that the command could accept additional arguments to run other steps. The assignee is currently assigned, so coordinate with them before starting.