momentum-design/momentum-ui

[Select] add `isLoading` for dynamically loading options

Open

#533 opened on Feb 3, 2020

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)SCSS (223 forks)auto 404
@core@react@vuehelp wanted

Repository metrics

Stars
 (212 stars)
PR merge metrics
 (PR metrics pending)

Description

Issue Type

Feature Request

Component or Pattern Affected

Select

Expected Behavior

When dynamically loading options to a select (all libraries) there needs to be a spinner in place of the caret and the click action should be disabled. The prop to enable/disable should be isLoading

Current Behavior

EmptyDeviceList

Contributor guide

Research direction
Locate the Select component implementation, understand the current click and caret rendering logic, then add an isLoading prop to show a spinner and disable interactions.
Tech stack
javascripttypescriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65