moment/luxon

Luxon not working on StackBlitz

Open

#552 opened on Aug 9, 2019

View on GitHub
 (1 comment) (2 reactions) (0 assignees)JavaScript (14,588 stars) (759 forks)batch import
help wantedissue: install/load

Description

With the introduction of the specific CDN rules (https://github.com/moment/luxon/pull/468), luxon no longer can be imported in StackBlitz. There is an issue for this over at StackBlitz (https://github.com/stackblitz/core/issues/986), but as far as I can see, this should be resolved here.

The problem is that the build/global file does not export anything, it just defines a variable called luxon that goes nowhere. This is not preferable, since the only way to import this, is by copying the file into another file (or using webpack, where it will magically work since you are copying everything in the same file, as specified by the original issue https://github.com/moment/luxon/issues/443.

Seems to me that the solution in #468 did not fix the problem, it only shifted it.

Proposal: Reverting #468 and reopening #443, figuring out what needs to be done exactly to resolve it.

Contributor guide

Tech stack
javascript
Domain
frontendtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScript module systemsLuxon build setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Examine the changes in PR #468 and the original issue #443 to understand the UMD export problem. The issue arises because the build/global file does not export anything; it only defines a variable. A potential fix involves adjusting the build configuration to properly export the luxon object as a module, or reverting the CDN changes and finding an alternative solution. Check if there are any recent comments or commits addressing this, and propose a fix that ensures the library can be imported in StackBlitz without copying files.