mohebifar/react-unforget

Prevent memoization of new Date and Math.random()

Open

#31 opened on Mar 13, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (4 forks)github user discovery
enhancementgood first issue

Repository metrics

Stars
 (386 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Not sure about a possible fix to this, but it appears to be memoizing impure function calls as well like Date.now(), new Date(), and Math.random()

https://github.com/mohebifar/react-unforget/assets/6689267/1bf52333-9f05-4a49-b817-a5ea63022556

Contributor guide

Research direction
Identify how the compiler currently tracks function purity and find where impure functions like Date.now() or Math.random() are incorrectly memoized. Review the memoization logic to exclude these calls.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Reactcompiler concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70