Resolved mcp_config still contains the full platform_overrides map

Open Beginner friendly
#265 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
84/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
typescript
Domain
backend

Research direction

Start in src/shared/config.ts:114-128 and inspect how getMcpConfigForManifest builds the resolved result. Reproduce the darwin/win32 case described in the issue, then verify that the selected override values remain while the returned config no longer contains platform_overrides.

Written by the indexing model from the issue text.

Description

Summary

getMcpConfigForManifest returns a resolved mcp_config that still carries the entire platform_overrides map (including other platforms' commands/env). The runtime config handed to the host is meant to be the resolved config, not the full override map.

Mechanism

src/shared/config.ts:114-128result = { ...baseConfig } shallow-copies, then the override branch overwrites command/args/env, but never removes result.platform_overrides. The returned object retains the full block.

Reproduction (executed)

Base config with darwin + win32 overrides, resolved on darwin → output has the correct command but still includes platform_overrides: { darwin: …, win32: … }.

Suggested fix

Drop the field after resolving:

delete result.platform_overrides;

(or construct result from explicit fields instead of spreading the whole base config).

Environment: current main (70fe3b3).

Dominant language
TypeScript
Stars
2.1k
Forks
210
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from modelcontextprotocol/mcpb

All issues in modelcontextprotocol/mcpb

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.