mobile-shell/mosh

Mosh timeout banner does not name the host(s) on the connection

Open

#1,049 opened on Jun 14, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (12,063 stars) (737 forks)batch import
good first issue

Description

Mosh's timeout banner at the top of the screen does not identify the host(s) involved. (mosh-client doesn't ever say which client or server hosts are involved, I think.) This can be momentarily confusing when you're using Mosh both into and out of a jump box, and one of the links dies-- you can't tell which Mosh session is offended at the situation. This is a pretty minor issue, but it just happened to me.

Contributor guide

Tech stack
cpp
Domain
cli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++ basicsMosh client code structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Look at the mosh client source code to find where the timeout banner is generated (likely in terminal setup or timeout handler). The banner currently does not include host identification. Modify the message to include the remote hostname, which is available from the connection state. No linked PRs or discussions exist. Ensure the change is backward compatible and follows the existing code style.
Mosh timeout banner does not name the host(s) on the connection · mobile-shell/mosh#1049 | Good First Issue