mllam/neural-lam

Rename d_mesh_static dimension to follow canonical naming convention

Open

#687 opened on Jun 27, 2026

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (276 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (282 stars)
PR merge metrics
 (PR metrics pending)

Description

Background

PR #635 added a "Canonical dimension names" list to the README, including:

  • d_mesh_static - number of static features per mesh node

In review of PR #635 it was noted that d_mesh_static doesn't match the naming pattern of the other canonical names: num_* for counts (num_state_vars, num_forcing_vars, num_grid_nodes, num_mesh_nodes) and *_dim for feature sizes (hidden_dim, input_dim). The d_-prefix follows neither.

Proposal

Rename d_mesh_static to num_mesh_static_vars, matching the num_* family.

Scope

The name predates #635 and also appears in code comments/docstrings, which should be updated together:

Separately, surrounding comments use ad-hoc node-count names (N_mesh, N_mesh_nodes_level) instead of the canonical num_mesh_nodes. Would be good to also fix

Contributor guide

Research direction
Find all occurrences of 'd mesh static' in the specified files and replace with 'num mesh static vars'. Also update surrounding comments that use ad hoc node count names like 'N mesh' to canonical 'num mesh nodes'.
Tech stack
python
Domain
machine learning
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80