Why MLC_ENABLE_SENTENCEPIECE_TOKENIZER OFF by default?
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cpp
- Domain
- build-system
Research direction
Start in CMakeLists.txt and inspect the default for MLC_ENABLE_SENTENCEPIECE_TOKENIZER, then trace the disabled path in src/sentencepiece_tokenizer.cc. Run ./build_and_run.sh with the current default and with the option enabled; done means the intended example target builds and runs without a manual configuration change, or the required configuration is clearly established.
Written by the indexing model from the issue text.
Description
Should MLC_ENABLE_SENTENCEPIECE_TOKENIZER be on by default in CMakeLists.txt? I had to turn it on in order to successfully run ./build_and_run.sh to build the example target. Otherwise, I get a assert failure at src/sentencepiece_tokenizer.cc:
#else
std::unique_ptr<Tokenizer> Tokenizer::FromBlobSentencePiece(const std::string& model_blob) {
assert(false);
throw;
}
#endif // MLC_ENABLE_SENTENCEPIECE_TOKENIZER
- Dominant language
- C++
- Stars
- 512
- Forks
- 132
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mlc-ai/tokenizers-cpp
-
Missing Cargo.lock Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
mlc-ai/tokenizers-cpp#96 · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
mlc-ai/tokenizers-cpp#88 · 2 reactions ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
mlc-ai/tokenizers-cpp#95 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
mlc-ai/tokenizers-cpp#94 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
mlc-ai/tokenizers-cpp#91 ·
All issues in mlc-ai/tokenizers-cpp
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
games-on-whales/wolf#509 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
bug-unconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 76/100