ml5js/ml5-library

[FeatureExtractor & KNN Classifier] Load Models support in p5 web editor

Open

#686 opened on Nov 6, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (6,136 stars) (905 forks)batch import
bugfeature-extractorhelp wantedknn-classification

Description

Dear ml5 community,

I'm submitting a new issue. Please see the details below.

→ Step 1: Describe the issue 📝

Did you find a bug? Want to suggest an idea for feature?

  • bug / enhancement

Loading models back to the KNNClassifier and FeatureExtractor seems to create some problems in the p5 web editor. We resolved these issues in the Neuralnetwork class with a few tricks. This issue is to make sure that we are consistent about support and the mechanisms for loading and saving models.

Contributor guide

Tech stack
javascript
Domain
machine learning
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
unclear
Prerequisites
familiarity with ml5.jsknowledge of FeatureExtractor and KNNClassifier
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate how loading models was handled for the NeuralNetwork class (see commit history or related PRs). Look at the FeatureExtractor and KNNClassifier source files, likely in src/ directory. The issue lacks specifics, so try to reproduce the problem in the p5 web editor and identify the differences in load/save mechanisms. Check if there are any existing tests or comments about this issue.