Layout remounts on every paths
@rifat-ml is already working on this.
Since Jun 16, 2022.
- #149 by @rifat-ml — closed without merging
Assessment
This issue has not been assessed yet.
Description
There are three types of layouts currently we've on this template:
- Blank Layout
- Sidebar Layout
- Header Layout
On public paths like authentication and registration, we've used the Blank Layout and for private paths, we've options to choose different layouts like Sidebar Layout and Header Layout. So whatever the layout is the same layout shouldn't be remounted on every path change. But currently, the same layout is remounting on every path change. That is an issue in some cases as the sidebar or navbar sometimes shuts and opens unexpectedly while toggling. And also it's a heavy operation on DOM to mount and unmount which is unnecessary in this situation.
- Dominant language
- TypeScript
- Stars
- 23
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ml-opensource/admin-panel-template-reactjs
-
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 20/100
ml-opensource/admin-panel-template-reactjs#123 · 2 comments ·
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
ml-opensource/admin-panel-template-reactjs#78 · 1 comment ·
All issues in ml-opensource/admin-panel-template-reactjs
Similar issues
-
check:passed streams:add
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Fission-AI/OpenSpec#1986 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
nestjs/docs.nestjs.com#3554 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
publicodes/publicodes#868 ·
-
namespace operations
Difficulty 1/5 Under an hour Newbie friendliness 78/100
EclipseFdn/open-vsx.org#13488 ·
Maintainers usually reply within 2 days