mjackson/expect

Make `toNotThrow` say what was thrown

Open

#193 opened on Feb 3, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (2,290 stars) (132 forks)batch import
enhancementhelp wanted

Description

expect(() => foo()).toNotThrow

fails when foo throws, but it doesn't tell me what error foo threw. This would be really useful for debugging. I'm happy to make a PR :)

PS: I'm also happy to try to help out more if you need help with this module :)

Contributor guide

Tech stack
javascript
Domain
testing
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptunderstanding of testing assertions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue requests that the `toNotThrow` assertion method include the actual thrown error in the failure message. To implement this, locate the `toNotThrow` implementation in the repository (likely in `lib/expect.js` or similar). Modify the assertion to capture the thrown error and include it in the message. Refer to existing assertions like `toThrow` for how error messages are formatted. No linked PRs or assignees, so the issue is available for contribution.