mjackson/expect

Make `toNotThrow` say what was thrown

Open

#193 opened on Feb 3, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (132 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (2,290 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

expect(() => foo()).toNotThrow

fails when foo throws, but it doesn't tell me what error foo threw. This would be really useful for debugging. I'm happy to make a PR :)

PS: I'm also happy to try to help out more if you need help with this module :)

Contributor guide

Research direction
Look at the toNotThrow implementation in the expect library. Modify it to catch the thrown error and include its message in the assertion failure message.
Tech stack
javascript
Domain
testing
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80