Clean up builder interaction

Open
#15 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Quiet
Tech stack
cpp
Domain
backend

Research direction

Start at include/imalgs/FIMAircraftIntent.h lines 38-42 and trace where the integer and string IDs are used across the codebase. Inspect ScenarioUtils for cases where integer-based code cannot be removed cleanly. Done means the string ID remains authoritative, redundant integer-ID usage is removed where practical, and remaining conversions are handled through ScenarioUtils.

Written by the indexing model from the issue text.

Description

https://github.com/mitre/im_sample_algorithm/blob/d7b5a8e8abd8a26cd2ee1984192a2d35e6b94567/include/imalgs/FIMAircraftIntent.h#L38-L42

These lines show confusion. There should not be both integer id and string id. And string id is paramount. Attempt to fully remove the interger concept from the codebase, retaining the string. If there is code that uses the interger and is not easily refactored away, then use ScenarioUtils to handle that.

Dominant language
C++
Stars
2
Forks
2
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mitre/im_sample_algorithm

All issues in mitre/im_sample_algorithm

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.