miraclx/freyr-js

freyr downloading song that has gameplay audio

Open

#651 opened on Jan 29, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (2,279 stars) (154 forks)user submission
buggood first issue

Description

for some reason, when I've downloaded certain tracks that are from video games, freyr gives me tracks that have gameplay audio in them

examples: Camellia - Tempo Katana - Spotify Link: https://open.spotify.com/album/3LrSsAtkvSfVdxabXiInCR?si=xi60lCjXTNy78T7H8pxx6Q

Camellia - LORELEI Spotify Link: https://open.spotify.com/album/6OzPAnOQtqvMV5wcrR3oG6?si=_qJLX1pSTJ-Nhl5PZQ58_Q

What freyr downloaded (for me at least): https://drive.google.com/drive/folders/1VZRM1dnO3HrQAT_cFCS4pjTZz1RzLoMS?usp=sharing

Contributor guide

Tech stack
javascriptnodejs
Domain
clitooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Understanding of Node.js and async/awaitFamiliarity with freyr js codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the download logic for tracks from Spotify, focusing on how the audio source is selected. Compare the URLs for tracks that download gameplay audio versus those that download the correct track. Start by examining the function that retrieves Spotify track data and see if there's a fallback to a different audio source. Reproduce with the provided examples to identify the pattern.
freyr downloading song that has gameplay audio · miraclx/freyr-js#651 | Good First Issue